Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse parameter types on test-collector's side #1700

Merged
merged 16 commits into from
Feb 21, 2024
Merged

Conversation

drknzz
Copy link
Contributor

@drknzz drknzz commented Feb 12, 2024

Closes #1394

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@drknzz drknzz marked this pull request as ready for review February 19, 2024 15:10
@drknzz drknzz requested review from a team as code owners February 19, 2024 15:10
@drknzz drknzz requested review from Arcticae, war-in, THenry14 and abulenok and removed request for a team February 19, 2024 15:10
Copy link
Contributor

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@drknzz drknzz added this pull request to the merge queue Feb 21, 2024
Merged via the queue into master with commit 4260e57 Feb 21, 2024
14 checks passed
@drknzz drknzz deleted the 1394-collector-types branch February 21, 2024 09:02
Draggu pushed a commit that referenced this pull request Feb 22, 2024
<!-- Reference any GitHub issues resolved by this PR -->

Closes #1394

## Introduced changes

<!-- A brief description of the changes -->
- Bump cairo to **2.5.4**
- Use changes introduced in
[software-mansion/scarb#1121](software-mansion/scarb#1121)

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make forge stop parse sierra types directly
5 participants