Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement loading shared libraries for proc macro plugins #1093

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Implement loading shared libraries for proc macro plugins #1093

merged 1 commit into from
Feb 21, 2024

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Jan 29, 2024 •
edited
Loading

This was referenced Jan 29, 2024
Merged
Closed
Merged
Merged
@maciektr maciektr requested a review from mkaput January 29, 2024 10:23
@maciektr maciektr force-pushed the spr/main/4d5003fc branch 2 times, most recently from e8d2f54 to 87eb720 Compare January 30, 2024 15:22
@maciektr maciektr force-pushed the spr/main/a3155bbf branch 2 times, most recently from e58ce04 to 7e29f2e Compare January 30, 2024 17:28
@maciektr maciektr mentioned this pull request Jan 30, 2024
Merged
@maciektr maciektr changed the base branch from spr/main/4d5003fc to main February 1, 2024 22:25
@maciektr maciektr mentioned this pull request Feb 1, 2024
Merged
@maciektr maciektr changed the base branch from main to spr/main/4d5003fc February 1, 2024 22:25
@maciektr maciektr changed the base branch from spr/main/4d5003fc to main February 2, 2024 14:29
@maciektr maciektr mentioned this pull request Feb 2, 2024
Merged
@maciektr maciektr changed the base branch from main to spr/main/4d5003fc February 2, 2024 14:29
@maciektr maciektr changed the base branch from main to spr/main/e59370d2 February 16, 2024 10:39
@maciektr maciektr changed the base branch from spr/main/e59370d2 to main February 19, 2024 13:00
@maciektr maciektr changed the base branch from main to spr/main/e59370d2 February 19, 2024 13:00
@maciektr maciektr mentioned this pull request Feb 19, 2024
Merged
@maciektr maciektr force-pushed the spr/main/a3155bbf branch 2 times, most recently from 2d3823f to c92ec4c Compare February 19, 2024 13:52
@maciektr maciektr mentioned this pull request Feb 19, 2024
Merged
@maciektr maciektr mentioned this pull request Feb 19, 2024
Merged
mkaput
mkaput requested changes Feb 20, 2024
View reviewed changes
scarb/src/compiler/plugin/proc_macro/compilation.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/compilation.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/ffi.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/ffi.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/ffi.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/ffi.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/compilation.rs Outdated Show resolved Hide resolved
Base automatically changed from spr/main/e59370d2 to main February 21, 2024 00:26
github-merge-queue bot pushed a commit that referenced this pull request Feb 21, 2024
@maciektr
Implement procedural macro host generate_code for attribute macro (#…
336751b 
…1091)

Resolves #1127

commit-id:e59370d2

---

**Stack**:
- #1159
- #1157
- #1143
- #1151
- #1150
- #1148
- #1100
- #1155
- #1110
- #1093
- #1091 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr maciektr requested a review from mkaput February 21, 2024 10:20
mkaput
mkaput requested changes Feb 21, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/compilation.rs Outdated Show resolved Hide resolved
@maciektr maciektr requested a review from mkaput February 21, 2024 14:12
@maciektr maciektr added this pull request to the merge queue Feb 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 21, 2024
@maciektr maciektr added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 21e6d18 Feb 21, 2024
42 checks passed
@maciektr maciektr deleted the spr/main/a3155bbf branch February 21, 2024 17:11
@BrewTestBot BrewTestBot mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@tomek0123456789 tomek0123456789 Awaiting requested review from tomek0123456789

@szymmis szymmis Awaiting requested review from szymmis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement procedural macro package loading mechanism
2 participants
@maciektr @mkaput