Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement procedural macro host generate_code for attribute macro #1091

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

@maciektr maciektr requested a review from mkaput January 29, 2024 10:23
@maciektr maciektr force-pushed the spr/main/e59370d2 branch 2 times, most recently from 616a230 to 93ebb9d Compare January 30, 2024 15:22
@maciektr maciektr changed the base branch from spr/main/18967d01 to main February 1, 2024 22:25
@maciektr maciektr changed the base branch from main to spr/main/18967d01 February 1, 2024 22:25
@maciektr maciektr changed the base branch from spr/main/18967d01 to main February 2, 2024 14:29
@maciektr maciektr changed the base branch from main to spr/main/18967d01 February 2, 2024 14:29
@maciektr maciektr force-pushed the spr/main/e59370d2 branch 2 times, most recently from 7c819ff to 9b41634 Compare February 5, 2024 12:05
@maciektr maciektr changed the base branch from main to spr/main/18967d01 February 15, 2024 23:58
github-merge-queue bot pushed a commit that referenced this pull request Feb 16, 2024
commit-id:405d4728

---

**Stack**:
- #1143
- #1148
- #1100
- #1110
- #1093
- #1091
- #1060
- #1149⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
github-merge-queue bot pushed a commit that referenced this pull request Feb 16, 2024
commit-id:18967d01

---

**Stack**:
- #1143
- #1148
- #1100
- #1110
- #1093
- #1091
- #1060⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/18967d01 to main February 16, 2024 10:37
Copy link
Contributor

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume TODO's are done later in the PR stack, right?

I noticed that the TokenStream is a simple String rn, we want to change it to be an iterator over tokens later on, right?

After digging into the code - LGTM

scarb/src/compiler/plugin/proc_macro/host.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/host.rs Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/host.rs Outdated Show resolved Hide resolved
@maciektr maciektr added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit 336751b Feb 21, 2024
21 checks passed
@maciektr maciektr deleted the spr/main/e59370d2 branch February 21, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement foundations of Procedural Macro Host
3 participants