-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement procedural macro host generate_code
for attribute macro
#1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2024
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
January 30, 2024 13:51
e0ed0cd
to
a98c18e
Compare
maciektr
force-pushed
the
spr/main/18967d01
branch
from
January 30, 2024 13:51
5919332
to
a9e034d
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
2 times, most recently
from
January 30, 2024 15:22
616a230
to
93ebb9d
Compare
maciektr
force-pushed
the
spr/main/18967d01
branch
from
January 30, 2024 15:22
a9e034d
to
615455a
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
January 30, 2024 17:28
93ebb9d
to
65932a9
Compare
maciektr
force-pushed
the
spr/main/18967d01
branch
from
January 30, 2024 17:28
615455a
to
46e67f3
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
February 1, 2024 13:38
65932a9
to
64770c9
Compare
maciektr
force-pushed
the
spr/main/18967d01
branch
from
February 1, 2024 13:38
46e67f3
to
040aff1
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
February 2, 2024 14:29
64770c9
to
d18d182
Compare
maciektr
force-pushed
the
spr/main/18967d01
branch
from
February 5, 2024 11:30
85cc106
to
d2d34a4
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
2 times, most recently
from
February 5, 2024 12:05
7c819ff
to
9b41634
Compare
maciektr
force-pushed
the
spr/main/18967d01
branch
from
February 5, 2024 12:05
d2d34a4
to
4b225c6
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
February 5, 2024 12:59
9b41634
to
888454f
Compare
maciektr
force-pushed
the
spr/main/18967d01
branch
from
February 5, 2024 12:59
4b225c6
to
718a38b
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
February 5, 2024 16:13
888454f
to
7da8cf8
Compare
maciektr
force-pushed
the
spr/main/18967d01
branch
from
February 5, 2024 16:13
718a38b
to
1bbe096
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
February 15, 2024 23:58
a723696
to
722edbd
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
February 16, 2024 09:21
722edbd
to
a6d7151
Compare
maciektr
force-pushed
the
spr/main/18967d01
branch
from
February 16, 2024 09:21
1f70124
to
e26caab
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
February 16, 2024 10:39
a6d7151
to
f6eca64
Compare
maciektr
commented
Feb 16, 2024
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
February 19, 2024 13:00
f6eca64
to
242e3f5
Compare
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
February 19, 2024 16:14
242e3f5
to
73df971
Compare
This was referenced Feb 19, 2024
piotmag769
reviewed
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume TODO's are done later in the PR stack, right?
I noticed that the TokenStream
is a simple String
rn, we want to change it to be an iterator over tokens later on, right?
After digging into the code - LGTM
piotmag769
approved these changes
Feb 19, 2024
piotmag769
reviewed
Feb 19, 2024
Resolves #1127 commit-id:e59370d2
maciektr
force-pushed
the
spr/main/e59370d2
branch
from
February 20, 2024 23:31
73df971
to
3eb02fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1127
commit-id:e59370d2
Stack:
generate_code
for attribute macro #1091 ⬅