Use dev-deps during compilation in snforge-test-collector
#1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotmag769
requested review from
tomek0123456789,
szymmis,
maciektr and
mkaput
as code owners
piotmag769
force-pushed
the
fix-dev-deps-test-collector
branch
from
95318c0
to
fe389a7
Compare
piotmag769
force-pushed
the
fix-dev-deps-test-collector
branch
from
fe389a7
to
ba41e86
Compare
piotmag769
force-pushed
the
fix-dev-deps-test-collector
branch
from
ba41e86
to
418b940
Compare
piotmag769
requested review from
MaksymilianDemitraszek and
Arcticae
and removed request for
cptartur
Arcticae
approved these changes
Jan 8, 2024
maciektr
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes foundry-rs/starknet-foundry#1460
The solution is to fetch dependencies from unit test compilation unit.
After talking with @mkaput we decided that to ensure this heuristic solution doesn't break we check if all other test compilation units have the same dependencies (excluding dependencies being sources for integration tests i. e., starting with
{package_path}/tests/).