Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include dev-dependencies in test compilation #1460

Closed
piotmag769 opened this issue Jan 2, 2024 · 1 comment · Fixed by software-mansion/scarb#1033
Closed

Include dev-dependencies in test compilation #1460

piotmag769 opened this issue Jan 2, 2024 · 1 comment · Fixed by software-mansion/scarb#1033
Assignees
@piotmag769
Labels
bug Something isn't working snforge test-collector

Comments

@piotmag769
Copy link
Member

The simplest solution may be to prioritize test target over starknet-contract target here, but it has to be investigated if it works.
Appropriate tests should be added.
@github-actions github-actions bot added the new label Jan 2, 2024
@piotmag769 piotmag769 self-assigned this Jan 3, 2024
@piotmag769 piotmag769 removed the new label Jan 3, 2024
@piotmag769 piotmag769 mentioned this issue Jan 4, 2024
Merged
@piotmag769
Copy link
Member Author

PR: software-mansion/scarb#1033

github-merge-queue bot pushed a commit to software-mansion/scarb that referenced this issue Jan 8, 2024
@piotmag769
Use dev-deps during compilation in snforge-test-collector (#1033)
1fe9f8f 
Closes foundry-rs/starknet-foundry#1460

The solution is to fetch dependencies from unit test compilation unit.

After talking with @mkaput we decided that to ensure this heuristic
solution doesn't break we check if all other test compilation units have
the same dependencies (excluding dependencies being sources for
integration tests i. e., starting with `{package_path}/tests/`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotmag769 piotmag769

Labels
bug Something isn't working snforge test-collector
Projects
Starknet foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use dev-deps during compilation in snforge-test-collector software-mansion/scarb
1 participant
@piotmag769