-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for unsupported platforms #22
Fix for unsupported platforms #22
Conversation
This reverts commit 118068e.
Prepare for next PR
1cf2aea
to
5992ef2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brunolemos This is 💯
hey @brunolemos I was just testing it and it appears this just disables screens completely on mobile. The reason is that packager picks screens.js first which does not include any references to native containers. Would it be ok if I rename screen.js -> screens.web.js? |
I actually went ahead and made these changes (now we only have I published it on NPM under 1.0.0-alpha.14, do you mind testing this with your react native web project when you get a minute @brunolemos ?? |
This is weird, the default packager is supposed to prioritize But ok, just tested your changes and it worked on web so all fine! The way you did is cleaner, but I avoided doing this way because |
Thanks for checking! I wouldn't be concerned about other native platforms as long as they have |
Fixes #13 for real
Fixes react-navigation/react-navigation#5004
Use different
index.js
files for supported and unsupported platforms.Tested on iOS and on an existing web project that uses react-navigation.
Necolas explained here that this import should not be on any file that runs on web: necolas/react-native-web#507 (comment)