Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screens.web.js with stubs for Screen and ScreenContainer #13

Closed
brentvatne opened this issue Sep 19, 2018 · 1 comment
Closed

Add screens.web.js with stubs for Screen and ScreenContainer #13

brentvatne opened this issue Sep 19, 2018 · 1 comment

Comments

@brentvatne
Copy link
Contributor

As per react-navigation/react-navigation#5004 this would resolve react-navigation on web issues.

@brentvatne brentvatne changed the title Add screens.web.js Add screens.web.js with stubs for Screen and ScreenContainer Sep 19, 2018
@kmagiera
Copy link
Member

Closing as of #16

kmagiera pushed a commit that referenced this issue Oct 2, 2018
Fixes #13 for real
Fixes react-navigation/react-navigation#5004

Use different `index.js` files for supported and unsupported platforms.

Tested on iOS and on an existing web project that uses react-navigation.

---

!['react-native' does not contain an export named 'requireNativeComponent'.](https://user-images.githubusercontent.com/619186/46323012-8164e300-c5c2-11e8-964e-b6f233776dab.png)

Necolas explained here that this import should not be on any file that runs on web: necolas/react-native-web#507 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants