Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce abort-after-seconds #19

Merged
merged 7 commits into from
Oct 21, 2020
Merged

Introduce abort-after-seconds #19

merged 7 commits into from
Oct 21, 2020

Conversation

GMNGeoffrey
Copy link
Contributor

This has similar behavior to continue-after-seconds, but instead of
continuing, it aborts the step with a failure.

Resolves #18

@GMNGeoffrey
Introduce abort-after-seconds
0e1e145 
This has similar behavior to continue-after-seconds, but instead of
continuing, it aborts the step with a failure.

Resolves softprops#18
@GMNGeoffrey
Generate Minified JS
29d51c7
@GMNGeoffrey
Copy link
Contributor Author

@softprops PTAL

@GMNGeoffrey
Copy link
Contributor Author

Not sure why the tests are failing in the action. They pass locally. Seems like a version skew?

    TypeError [ERR_INVALID_ARG_VALUE]: The argument 'error' may not be an empty object. Received Error: Aborted after waiting 1 seconds

      92 |         await assert.rejects(
      93 |           waiter.wait(),
    > 94 |           new Error(`Aborted after waiting 1 seconds`)
         |           ^
      95 |         );
      96 |         assert.deepEqual(messages, [
      97 |           "✋Awaiting run  ...",

@GMNGeoffrey
Copy link
Contributor Author

I did a diff of npm ls within the action and locally and there are no differences (other than the local path).

@GMNGeoffrey
Copy link
Contributor Author

@softprops ping on this?

jonnyarnold
jonnyarnold reviewed Oct 21, 2020
View reviewed changes
__tests__/wait.test.ts Outdated Show resolved Hide resolved
@GMNGeoffrey
Copy link
Contributor Author

@softprops now passing thanks to @jonnyarnold. Can you take a look?

@softprops
Copy link
Owner

@GMNGeoffrey looks excellent!

@softprops softprops merged commit 5cec886 into softprops:master Oct 21, 2020
@GMNGeoffrey GMNGeoffrey mentioned this pull request Nov 13, 2020
Merged
GMNGeoffrey added a commit to google/llvm-bazel that referenced this pull request Nov 13, 2020
@GMNGeoffrey
Move turnstyle timeout into the step (#91)
600a42e 
Now possible with the introduction of `abort-after-seconds` in
softprops/turnstyle#19. We've had a few
timeouts recently because the main branch got far behind `HEAD`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyarnold jonnyarnold jonnyarnold left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abort-after-seconds
3 participants
@GMNGeoffrey @softprops @jonnyarnold