-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abort-after-seconds #18
Comments
This seems pretty straightforward to implement. @softprops would you accept a PR for this feature? |
That sounds reasonable. Just to confirm the difference would be failing the job rather than pressing on? That makes sense to me. |
Yup, exactly. I figure it can throw an error in the waiter which will then propagate up to main |
This has similar behavior to continue-after-seconds, but instead of continuing, it aborts the step with a failure. Resolves softprops#18
Another use case is when you would like to send some sort of notification (a custom notification using Using |
In addition to the
continue-after-seconds
I could see a good use-case for anabort-after-seconds
option such that the waiting step doesn't exceed some limit. You could set atimeout-minutes
on the whole job but then you have to take into account how long you expect a normal run to take. Am I missing something? Can this be done another way already?The text was updated successfully, but these errors were encountered: