Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4.0 introduced breaking changes (dropping Node 6 support) #589

Closed
rwjblue opened this issue Sep 23, 2019 · 4 comments
Closed

3.4.0 introduced breaking changes (dropping Node 6 support) #589

rwjblue opened this issue Sep 23, 2019 · 4 comments

Comments

@rwjblue
Copy link

rwjblue commented Sep 23, 2019

I am very sorry to raise such an issue (I know its often pretty frustrating as a maintainer to have someone else tell me about "semver violations"), please understand that I am only reporting because I would also want to be aware of issues that consumers of my packages are facing.

The ws updated landed in #587 was a breaking change and releasing that updated as 3.4.0 means existing consumers that still support Node 6 environments are now broken. Since ws@7 drops support for Node 6 (for example, it uses object rest/spread), any Node 6 consumers that had been using ^3.3.1 (which worked fine) will now get 3.4.0 and receive errors when ws's lib/websocket.js is required.

Thank you for your time (and again, I apologize for the distasteful issue).

@nitbaby
Copy link

nitbaby commented Sep 25, 2019

Thanks for raising this issue. We are also stuck due to this

@nsgundy
Copy link

nsgundy commented Nov 13, 2019

Also ran into this issue. Clearly stating this minimum version requirement with the engines property in package.json would be appreciated so that one would know about it at the time of installing the package rather than finding out when running the code.

darrachequesne added a commit that referenced this issue Apr 15, 2020
Unfortunately, the 3.4.0 version (minor) introduced a breaking change
by removing support for Node.js 6.

See #589

Backported from master: 61e639b
@darrachequesne
Copy link
Member

Arf, sorry for that... I added the engines property in the package.json file in both master and 3.4.x branches, in order not to reproduce the error.

@darrachequesne
Copy link
Member

Closing now, as I don't think we can do anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants