-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scrollTo
helper
#698
Add scrollTo
helper
#698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good generally, tests and some more docs (thinking some examples) seem like a good next step...
d916356
to
9b0a99d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good, I think we need a few more tests for the various error conditions that we throw for.
18b0e76
to
182dc05
Compare
I think I've gotten CI fixed on master now, mind rebasing? |
182dc05
to
ff5d5d5
Compare
ff5d5d5
to
650ea72
Compare
Investigating why this is failing in Ember 2.0 for |
650ea72
to
ce068f5
Compare
I'd love to see this ported! |
ce068f5
to
e113a02
Compare
Removed scrolling of window/document, added tests for error states |
e113a02
to
77cfd55
Compare
Looks like a downstream package has dropped support for Node 6 without bumping major versions (therefore breaking CI for us when using "floating dependencies"). I reported the issue over in socketio/engine.io#589, but I'm not sure yet if they will fix the issue. If it does not look like they intend to resolve that issue in a day or so, I'll mark the floating dependencies CI run as an allowed failure so that we are unblocked. |
@rwjblue seems like this issue in socketio isn't getting fixed, would it be possible to allow this failure? |
@nlfurniss - We have dropped support for Node 8 and lower now, I think this will pass with a rebase... |
aae1605
to
e5652c7
Compare
e5652c7
to
a99326d
Compare
Rerolled yarn.lock in #814 and restarted the build here to try to fix those TS issues. |
passes 🎉 |
Thank you @nlfurniss! |
Is this missing from API.md? |
@amk221 yes it is, I'll create an issue to add it once this code is published in a non-beta version |
ah ok, just spotted randomly. 👍 |
Inspired by the
scrollTo
helper fromember-native-dom-helpers
.If people are receptive to this, I'll add some tests :)