Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests so we don't regress #789 #792

Closed
joshrabinowitz opened this issue Mar 16, 2022 · 0 comments · Fixed by #791
Closed

add tests so we don't regress #789 #792

joshrabinowitz opened this issue Mar 16, 2022 · 0 comments · Fixed by #791

Comments

@joshrabinowitz
Copy link
Collaborator

joshrabinowitz commented Mar 16, 2022 •
edited
Loading

we should have tests that confirm that .gitignore looks as expected before and after add (and maybe after other actions)
joshrabinowitz pushed a commit to joshrabinowitz/git-secret that referenced this issue Mar 21, 2022
test .gitignore has expected line count, for sobolevn#792
c794c03
@joshrabinowitz joshrabinowitz mentioned this issue Mar 21, 2022
Merged
joshrabinowitz added a commit that referenced this issue Mar 23, 2022
@joshrabinowitz
changes to .gitignore usage and testing in response to #789 (#791)
eefa106 
* test .gitignore has expected line count, for #792
* let 'add' append filenames to .gitignore in tests
* add comments related to #789
* fix test to allow for more output from 'add'
* improve error message output
* allow for extra output from 'add' in test
* tweaks as per shellcheck lint
* improve comments, cleanup code
* update changelog
* describe test better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changes to .gitignore usage and testing in response to #789 joshrabinowitz/git-secret
1 participant
@joshrabinowitz