bug: auto add multiple files to .gitignore file doesn't break into more than 1 newline in 0.4.0

[simkimsia]

What are the steps to reproduce this issue?

1. attempt to add more than 1 file before git ignore it git secret add <file1> <file2>
2. then git secret hide

What happens?

Then the .gitignore will add the file1 and file2 but on the same line.

See this for example

What were you expecting to happen?

the files auto added to .gitignore should appear in new lines

What versions of software are you using?

Operating system: (uname -a) Darwin kimsia-MBP2021 21.3.0 Darwin Kernel Version 21.3.0: Wed Jan 5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_ARM64_T6000 arm64

git-secret path: (which git-secret) /opt/homebrew/bin/git-secret

git-secret version: (git secret --version) 0.4.0

git version: (git --version) … git version 2.32.0 (Apple Git-132)

Shell type and version: ($SHELL --version) zsh 5.8 (x86_64-apple-darwin21.0)

gpg version: (gpg --version)
gpg (GnuPG) 2.3.4
libgcrypt 1.10.0
Copyright (C) 2021 Free Software Foundation, Inc.
License GNU GPL-3.0-or-later https://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: /Users/kimsia/.gnupg
Supported algorithms:
Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
CAMELLIA128, CAMELLIA192, CAMELLIA256
AEAD: EAX, OCB
Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2

One-off contribution here

By the way, can you provide like a support? like pay 50 USD and we give you priority support to answer technical questions for 1 month.

I don't want to dictate features or affect the development cycle. Just want to get priority attention when it comes to technical questions for a short period of time (say 1 month)

[sobolevn]

Oh wow, thank you for your support! ❤️‍🔥
And of course, for your bug report.

like pay 50 USD and we give you priority support to answer technical questions for 1 month.

I like this idea, but there are several problems:

1. I live in Russia, right now we have temporary problems with international payments due to western sanctions. For example, GitHub Sponsors and OpenCollective do not work, because PayPal has blocked all Russian accounts (including mine). We will figure something out. For example, there are different Russian-native platforms for this kind of things
2. I charge 200$ per hour when doing consulting
3. Right now I have a big on-going project that takes almost all my time, I will be free ~ in 3 months

But, please, feel free to ask your questions here! I am sure that it will be addressed at some point.
Or maybe @joshrabinowitz wants to help you on a paid manner? He is even more active than me.

[simkimsia]

I wasn't aware of you based in Russia

I'm aware of the sanctions and sorry to hear about how it affects you

I sincerely hope the war ends soon

[joshrabinowitz]

I see what's going on.

Edit: this bug was introduced as part of a separate bug fix: 39ab72f

The fix for this issue, ac3b77a, was applied after the 0.4.0 release.

So this bug only effects the 0.4.0 release (and not 0.3.3 or before)

Seems like a good reason to make a new release as mentioned in #777

Edit: this is a duplicate/regression of #643 and #651

[joshrabinowitz]

@simkimsia wrote:

By the way, can you provide like a support? like pay 50 USD and we give you priority support to answer technical questions for 1 month.
I don't want to dictate features or affect the development cycle. Just want to get priority attention when it comes to technical questions for a short period of time (say 1 month)

Hey @simkimsia , I wrote you a message on your twitter account to discuss support options.
Please write me back there, maybe we can work something out!

[simkimsia]

Replied and also set up a test public repo to ask my questions. thank you