Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add css changes needed for new ls data-flow #564

Merged
merged 3 commits into from
Dec 16, 2024
Merged

chore: add css changes needed for new ls data-flow #564

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dff3d75
chore: add css changes needed for new ls data-flow
DariusZdroba Dec 12, 2024
8d7c23d
chore: remove unnecessary css
DariusZdroba Dec 12, 2024
ff42a4f
theme specific background image
DariusZdroba Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion media/views/snykCode/suggestion/suggestionLS.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
@import '../../common/webview';


.vscode-dark .data-flow-number{
background-image: linear-gradient(45deg, rgba(255, 255, 255, 0.075), rgba(255, 255, 255, 0.075));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this be pushed down to LS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, does the hardcoded gradient work on light and dark? I suppose we should use variables here :)

Copy link
Contributor Author

@DariusZdroba DariusZdroba Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a variable that would work with different themes, without adding anything else to VSCode, I could add the change to LS but on light mode, the background of the bubbles would be the same color as the "table"'s they're in. I could use variables but I think they would probabbly still need to be defined in VSCode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is still fine, I can add it to Language Server, but if we want to match the figma more, the bubbles should have the general background of the panel.
Screenshot 2024-12-13 at 11 51 53

Copy link
Contributor Author

@DariusZdroba DariusZdroba Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the background-color attribute and left it in LS, I left background-image and added theme specific style, if we specifically don't want to agglomerate CSS files, we could replace the variable depending on the theme, but I'm not sure if there would be much difference.

}
.vscode-light .data-flow-number{
background-image: linear-gradient(45deg, rgba(0, 0, 0, 0.05), rgba(0, 0, 0, 0.05));
}
.data-flow-text {
font-family: "Courier New", Courier, monospace;
}
Expand Down
Loading