chore: add css changes needed for new ls data-flow #564
Conversation
| @@ -1,5 +1,9 @@ | |||
| @import '../../common/webview'; | |||
|
|
|||
| .data-flow-number{ | |||
| background-color: var(--vscode-editor-background); | |||
| background-image: linear-gradient(45deg, rgba(255, 255, 255, 0.075), rgba(255, 255, 255, 0.075)); | |||
There was a problem hiding this comment.
can't this be pushed down to LS?
There was a problem hiding this comment.
Also, does the hardcoded gradient work on light and dark? I suppose we should use variables here :)
There was a problem hiding this comment.
I couldn't find a variable that would work with different themes, without adding anything else to VSCode, I could add the change to LS but on light mode, the background of the bubbles would be the same color as the "table"'s they're in. I could use variables but I think they would probabbly still need to be defined in VSCode.
There was a problem hiding this comment.
If this is still fine, I can add it to Language Server, but if we want to match the figma more, the bubbles should have the general background of the panel.
There was a problem hiding this comment.
I removed the background-color attribute and left it in LS, I left background-image and added theme specific style, if we specifically don't want to agglomerate CSS files, we could replace the variable depending on the theme, but I'm not sure if there would be much difference.
Description
Required changes to accommodate styling from the new data-flow design and addition of data-flows to AI fixes.
Related: snyk/snyk-ls#733
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!