-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle LS folderConfigs [IDE-502] #491
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
db4d7f6
feat: folderConfigs LS integration wip
ShawkyZ 69c9e77
fix: render base branch treenode correctly
ShawkyZ 2cf450d
feat: setBaseBranch command
ShawkyZ d660592
chore: lint
ShawkyZ 164d22d
fix: mock getFolderConfigs in tests
ShawkyZ 46afbdd
Merge branch 'main' into feat/delta-ls-config
ShawkyZ 1a0d289
fix: show base branch node if no issues found
ShawkyZ 88846b3
chroe: add missing keywords
7fe58c6
chore: update CHANGELOG.md
ShawkyZ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { FolderConfig, IConfiguration } from './configuration'; | ||
|
||
export interface IFolderConfigs { | ||
getFolderConfigs(config: IConfiguration): ReadonlyArray<FolderConfig>; | ||
|
||
resetFolderConfigsCache(): void; | ||
} | ||
|
||
export class FolderConfigs implements IFolderConfigs { | ||
private folderConfigsCache?: ReadonlyArray<FolderConfig>; | ||
|
||
getFolderConfigs(config: IConfiguration): ReadonlyArray<FolderConfig> { | ||
if (this.folderConfigsCache !== undefined) { | ||
return this.folderConfigsCache; | ||
} | ||
|
||
const folderConfigs = config.getFolderConfigs(); | ||
|
||
this.folderConfigsCache = folderConfigs; | ||
|
||
return folderConfigs; | ||
} | ||
|
||
setFolderConfig(_config: IConfiguration, _folderPath: string, _baseBranch: string) { | ||
// Get all folders and update one you need and use setFolderConfig. | ||
// if (this.folderConfigsCache !== undefined) { | ||
// return this.folderConfigsCache; | ||
// } | ||
|
||
Check failure on line 29 in src/snyk/common/configuration/folderConfig.ts GitHub Actions / Build and Test (ubuntu-latest)
|
||
// const folderConfigs = config.getFolderConfigs(); | ||
|
||
Check failure on line 31 in src/snyk/common/configuration/folderConfig.ts GitHub Actions / Build and Test (ubuntu-latest)
|
||
// this.folderConfigsCache = folderConfigs; | ||
|
||
// return folderConfigs; | ||
} | ||
|
||
resetFolderConfigsCache() { | ||
this.folderConfigsCache = undefined; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary if we want to enable trace logs later. The Language Client Id can't have an empty space