Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle LS folderConfigs [IDE-502] #491

Merged
merged 9 commits into from
Jul 19, 2024
Merged

feat: handle LS folderConfigs [IDE-502] #491

merged 9 commits into from
Jul 19, 2024

Conversation

ShawkyZ
Copy link
Contributor

@ShawkyZ ShawkyZ commented Jul 18, 2024

Description

  • Append folderConfigs to settings.json.
  • Add a command for the base branch tree node to set the base branch in the configs

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@@ -118,7 +119,7 @@ export class LanguageServer implements ILanguageServer {
};

// Create the language client and start the client.
this.client = this.languageClientAdapter.create('Snyk LS', SNYK_LANGUAGE_SERVER_NAME, serverOptions, clientOptions);
this.client = this.languageClientAdapter.create('SnykLS', SNYK_LANGUAGE_SERVER_NAME, serverOptions, clientOptions);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary if we want to enable trace logs later. The Language Client Id can't have an empty space

@ShawkyZ ShawkyZ marked this pull request as ready for review July 19, 2024 13:52
@ShawkyZ ShawkyZ requested a review from a team as a code owner July 19, 2024 13:52
Copy link
Contributor

@cat2608 cat2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ShawkyZ ShawkyZ merged commit fcea0e8 into main Jul 19, 2024
14 checks passed
@ShawkyZ ShawkyZ deleted the feat/delta-ls-config branch July 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants