chore: add .light-only and .dark-only rules to LS CSS
#472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cat2608
commented
Jun 12, 2024
CHANGELOG.md
Outdated
Comment on lines
3
to
5
| ## [2.12.3] | ||
| - Add CSS rules for `.light-only` and `.dark-only` to the LSP implementation. This allows the LSP to apply different styles based on the current theme. | ||
|
|
There was a problem hiding this comment.
This is in case we merge first #471
There was a problem hiding this comment.
I left a comment in snyk/snyk-ls#540 (comment) about a different way to do this, that would maybe take care of IntelliJ too. WDYT?
4 tasks
cat2608
force-pushed
the
refactor/IDE-294-replace-tabs-with-arrows
branch
from
2824a5e to
84b0666
Compare
teodora-sandu
approved these changes
Jun 13, 2024
Thanks for approving this change 🙏 In this PR for IntelliJ I explain why I decided to go for this approach. I tried your suggestion, but I couldn't figure out how to choose between values for the stroke field when the user was changing the theme between light, dark, and high contrast. We can revisit this approach if you like :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Screenshots / GIFs