Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: applying AI code fixes on Windows [IDE-395] #471

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

ShawkyZ
Copy link
Contributor

@ShawkyZ ShawkyZ commented Jun 12, 2024

Description

  • use fspath instead of path.
  • parse file path Uri using vscode.vscode.Uri.file(filePath) instead of vscode.Uri.parse(filePath)
    Difference is
vscode.Uri.file(filePath).fsPath
'c:\\Users\\user\\work\\project-with-vulns\\copy.ts'
vscode.Uri.parse(filePath).fsPath
'\\Users\\user\\work\\project-with-vulns\\copy.ts'

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@ShawkyZ ShawkyZ requested a review from a team as a code owner June 12, 2024 12:35
CHANGELOG.md Outdated Show resolved Hide resolved
@ShawkyZ ShawkyZ enabled auto-merge (squash) June 12, 2024 15:35
@ShawkyZ ShawkyZ merged commit 614d382 into main Jun 12, 2024
7 checks passed
@ShawkyZ ShawkyZ deleted the fix/aifix-windows branch June 12, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants