fix: track 'Welcome View Is Viewed' event on view toggle [ROAD-120] #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michelkaporin
commented
Jul 5, 2021
•
michelkaporin
commented
- Track 'Welcome View Is Viewed' event on view toggle instead of extension activation as it is now.
- Flush event on extension deactivation and uninstall
- Point Iteratively to the main branch
michelkaporin
changed the title
michelkaporin
force-pushed
the
fix/logwelcomeview-event
branch
from
393f458 to
cfa10ac
Compare
michelkaporin
force-pushed
the
fix/logwelcomeview-event
branch
from
4881a7e to
2e93329
Compare
pavel-snyk
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
@michelkaporin, LGTM.
p.s.: somehow GH cannot display diff "normal" in src/snyk/extension.ts. It took me a while to compare the code :).
This was referenced Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.