feat: utilise itly.flush to ensure event delivery [ROAD-120] #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michelkaporin
commented
Jul 2, 2021
michelkaporin
commented
- Use itly.flush() to ensure event queue is delivered when extension is deactivated or uninstalled.
- Flush after 'Plugin is Installed' event to prevent out of order delivery.
pavel-snyk
reviewed
Jul 2, 2021
| @@ -149,6 +151,8 @@ export class Iteratively { | |||
| }, | |||
| }, | |||
| ); | |||
|
|
|||
| return itly.flush(); | |||
There was a problem hiding this comment.
@michelkaporin, question: why we need to call flush after pluginIsInstalled?
There was a problem hiding this comment.
@pavel-snyk to prevent out of order event delivery that happens between 'Plugin is Installed' and 'Welcome is Viewed' events currently. They are fired one after another and Iteratively/Segment ingest them out of order for some reason.
|
Closed in favour of #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.