chore: correction on diagnostic example in readme #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
bastiandoetsch
approved these changes
Oct 11, 2024
cmars
force-pushed
the
chore/correction-scan-issue-readme
branch
from
1fa2c19 to
f98a0e4
Compare
Removing a phantom attribute that doesn't actually exist in the Diagnostic type, from README examples.
cmars
force-pushed
the
chore/correction-scan-issue-readme
branch
from
0263612 to
f0e7063
Compare
Test_initialize_handlesUntrustedFoldersWhenAuthenticated is failing in CI but not locally. This is likely due to too-short a timeout waiting for an async condition. 5s timeout chosen based on similar increase in a similar test in 68b6aa8.
cmars
force-pushed
the
chore/correction-scan-issue-readme
branch
from
f0e7063 to
23d0d33
Compare
cmars
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing a phantom attribute that doesn't actually exist in the Diagnostic type, from README examples.
Checklist