chore: improve custom lsp extension docs #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README with more examples of custom notifications and types which may be useful to integrating with the Snyk Language Server. Rename "payload" to "params", "response" to "example" in notification docs.
cmars
force-pushed
the
chore/improve-readme-lsp-docs
branch
from
eb51089 to
17887df
Compare
| "message": "Message", | ||
| "tags": ["security"], | ||
| "data": { | ||
| "scanIssue": { |
There was a problem hiding this comment.
Is this correct? I thought it is the struct directly, without json key.
There was a problem hiding this comment.
You're right. Correction in #699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update README with more examples of custom notifications and types which may be useful to integrating with the Snyk Language Server.
Rename "payload" to "params", "response" to "example" in notification docs. This is to better align with the wording used in the LSP specification regarding notifications.
Checklist