feat: Delete local .iac-data directory after scan is finished, using fs [CC-765] #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ipapast
changed the title
ipapast
force-pushed
the
refactor/clean-up-local-iac-cache-rmdirsync
branch
from
ea5deed
to
bbb17be
Compare
|
Closing PR as rimraf was used instead #1762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In a previous task, we introduced the download and extraction of files in a local cache directory, called '.iac-data'.
We do not need the files anymore after the scan/test, so we decided to clean up that local directory after the tests finishes.
How should this be manually tested?
npm run build && node iac test file.tf --experimentalls .iac-dataand see that there is no such directory in the filesystem anymore.What are the relevant tickets?
CC-765