feat: Delete local .iac-data directory after scan is finished [CC-765]

[ipapast]

• Follows CONTRIBUTING rules

What does this PR do?

In a previous task, we introduced the download and extraction of files in a local cache directory, called '.iac-data'.

We do not need the files anymore after the scan/test, so we decided to clean up that local directory after the tests finishes.

We also move the dev dependency rimraf from dev deps to prod deps. When we support Node >= v12.10.0 we can switch to the supported rmdirSync with recursive options.
https://snyk.slack.com/archives/C0127HWU0E7/p1616688051070900

How should this be manually tested?

• Run npm run build && node iac test file.tf --experimental
• Run ls .iac-data and see that there is no such directory in the filesystem anymore.

Any background context you want to provide?

The package rimraf was used for the deletion of the directory. This was already in our dev dependencies.

Option 2:
In our version of node fs.rmdirSync is not supported, so in order to delete a non empty directory we would need to make our own recursive function, to check for files in the directory, unlink them and then delete them one by one. Rimraf does this in one line. That function would look like this:

export const cleanLocalCache = (directoryPath) => {
  if (fs.existsSync(directoryPath)) {
    fs.readdirSync(directoryPath).forEach((file) => {
      const curPath = path.join(directoryPath, file);
      fs.unlinkSync(curPath);
    });
    fs.rmdirSync(directoryPath);
  } else {
    console.log('Directory path not found');
  }
};

What are the relevant tickets?

CC-765

[aron]

👍 Very nice, shall we add a note above the rimraf import/call site that says it can be removed when minimum node version is above 12.x?

[ipapast]

👍 Very nice, shall we add a note above the rimraf import/call site that says it can be removed when minimum node version is above 12.x?

Good call, I'll add that now

[github-actions]

Expected release notes (by @ipapast)

features:
delete iac cache directory after test (b6803e8)

others (will not be included in Semantic-Release notes):
Remove SNYK_IAC_SKIP_BUNDLE_DOWNLOAD flag for IaC (29db293)
target node14.4.0 instead of node14 to fix build (1ce0d11)
iac smoke tests to be less explicit (2d6cd7e)
fix broken IaC smoke test (259c263)
remove now-redundant and excessively complex acceptance tests (20d560b)
refactor and improve testing (afdf3b3)

• I hereby acknowledge these release notes are 🥙 AWESOME 🥙

[ghost]

Not blocking, but this if guard shouldn't be needed as rimraf already checks and succeeds if the directory doesn't exist.

If the file doesn't exist, rimraf will return successfully, since your desired outcome is already the case.

Source: https://github.com/isaacs/rimraf

[ipapast]

Good call, I'll merge it right after this. thank you!