Add CommonEventProperties type argument #1250

igneel64 · 2023-10-11T10:42:39Z

bundlemon · 2023-10-11T10:51:11Z

BundleMon

Files added (6)

Status	Path	Size	Limits
✅	libraries/browser-tracker-core/dist/index.mod ule.js	+25.32KB	26KB / +10%
✅	trackers/javascript-tracker/dist/sp.js	+24.18KB	25KB / +10%
✅	trackers/javascript-tracker/dist/sp.lite.js	+14.86KB	15KB / +10%
✅	trackers/browser-tracker/dist/index.umd.min.j s	+14.7KB	15KB / +10%
✅	libraries/tracker-core/dist/index.module.js	+13.35KB	15KB / +10%
✅	trackers/browser-tracker/dist/index.module.js	+3.51KB	5KB / +10%

Total files change +95.92KB 0%

Final result: ✅

matus-tomlein

LGTM! Have separated out issue #1251 for the track function types as we discussed.

igneel64 requested a review from matus-tomlein October 11, 2023 10:42

Add CommonEventProperties type argument (close #1249)

e55e715

igneel64 force-pushed the feature/1249-common-event-properties-type-arg branch from aee49bd to e55e715 Compare October 11, 2023 10:45

matus-tomlein approved these changes Oct 12, 2023

View reviewed changes

igneel64 changed the base branch from master to release/3.16.0 October 12, 2023 15:08

igneel64 merged commit 23b0c02 into release/3.16.0 Oct 12, 2023
2 checks passed

igneel64 deleted the feature/1249-common-event-properties-type-arg branch October 12, 2023 15:09

igneel64 restored the feature/1249-common-event-properties-type-arg branch October 17, 2023 08:04