Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for type argument for CommonEventProperties #1249

Closed
igneel64 opened this issue Oct 11, 2023 · 0 comments · Fixed by #1250
Closed

Allow for type argument for CommonEventProperties #1249

igneel64 opened this issue Oct 11, 2023 · 0 comments · Fixed by #1250
Labels
type:enhancement New features or improvements to existing features.

Comments

@igneel64
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Allow for type argument option in CommonEventProperties

Describe the solution you'd like
CommonEventProperties<T> that will trickle down to the allowed contexts in SDEs.
@igneel64 igneel64 added the type:enhancement New features or improvements to existing features. label Oct 11, 2023
igneel64 added a commit that referenced this issue Oct 11, 2023
@igneel64
Add CommonEventProperties type argument (close #1249)
aee49bd
@igneel64 igneel64 mentioned this issue Oct 11, 2023
Merged
igneel64 added a commit that referenced this issue Oct 11, 2023
@igneel64
Add CommonEventProperties type argument (close #1249)
e55e715
@matus-tomlein matus-tomlein mentioned this issue Oct 12, 2023
Open
igneel64 added a commit that referenced this issue Oct 12, 2023
@igneel64
Add CommonEventProperties type argument (close #1249)
23b0c02 
#1250
@matus-tomlein matus-tomlein mentioned this issue Oct 12, 2023
Merged
igneel64 added a commit that referenced this issue Oct 16, 2023
@igneel64
Add CommonEventProperties type argument (close #1249)
fed8695
@igneel64 igneel64 mentioned this issue Oct 17, 2023
Merged
igneel64 added a commit that referenced this issue Oct 17, 2023
@igneel64
Add CommonEventProperties type argument (close #1249)
3d4e8c9
igneel64 added a commit that referenced this issue Nov 14, 2023
@igneel64
Add CommonEventProperties type argument (close #1249)
0008f6e 
#1254
@igneel64 igneel64 mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement New features or improvements to existing features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CommonEventProperties type argument snowplow/snowplow-javascript-tracker
1 participant
@igneel64