Add alert & retry for delta/s3 initialization #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
reviewed
Jul 31, 2024
Comment on lines
46
to
49
| case _: AccessDeniedException => | ||
| // 1 - no permission to see s3 bucket | ||
| // 2 - not authorized to assume the role | ||
| true |
There was a problem hiding this comment.
Please can you explain to me under which circumstances you get a AccessDeniedException?
Can you confirm I've understood your code comments correctly....
- If the bucket doesn't exist, or we don't have permission to see the bucket itself --> get a
UnknownStoreException - If we don't have access to read/write objects inside the bucket --> get a
DeltaIOException
...so I can't work out what scenario gives a AccessDeniedException.
There was a problem hiding this comment.
I can't work out what scenario gives a AccessDeniedException.
we get AccessDeniedException in these cases:
- when the bucket's policy denies all actions, we get AccessDeniedException without any error message
- when we try to assume a role that doesn't exist, we get AccessDeniedException with detailed error message
I see that my comment on L47 is misleading
There was a problem hiding this comment.
just pushed a commit to describe exact situation
istreeter
approved these changes
Aug 1, 2024
zhaow-de
added a commit
to alloy-ch/rcplus-alloy-snowplow-lake-loader
that referenced
this pull request
Oct 4, 2024
…patch-for-alloy * commit '7ab2edc3fd4d81ffb4d5f3285d02330def7672b1': Upgrade common-streams to 0.8.0-M5 Delete files asynchronously (snowplow-incubator#82) Upgrade common-streams 0.8.0-M4 (snowplow-incubator#81) Avoid error on duplicate view name (snowplow-incubator#80) Add option to exit on missing Iglu schemas (snowplow-incubator#79) common-streams 0.8.x with refactored health monitoring (snowplow-incubator#78) Create table concurrently with subscribing to stream of events (snowplow-incubator#77) Iceberg fail fast if missing permissions on the catalog (snowplow-incubator#76) Make alert messages more human-readable (snowplow-incubator#75) Hudi loader should fail early if missing permissions on Glue catalog (snowplow-incubator#72) Add alert & retry for delta/s3 initialization (snowplow-incubator#74) Implement alerting and retrying mechanisms Bump aws-hudi to 1.0.0-beta2 (snowplow-incubator#71) Bump hudi to 0.15.0 (snowplow-incubator#70) Allow disregarding Iglu field's nullability when creating output columns (snowplow-incubator#66) Extend health probe to report unhealthy on more error scenarios (snowplow-incubator#69) Fix bad rows resizing (snowplow-incubator#68)
oguzhanunlu
added a commit
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: PDP-1322