Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade common-streams to 0.8.0-M6 #386

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Upgrade common-streams to 0.8.0-M6 #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/config.pubsub.reference.hocon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
# -- The actual value used is guided by runtime statistics collected by the pubsub client library.
"minDurationPerAckExtension": "60 seconds"
"maxDurationPerAckExtension": "600 seconds"

# -- Max num of streaming pulls to open per transport channel
"maxPullsPerTransportChannel": 16
}

"output": {
Expand Down
2 changes: 1 addition & 1 deletion modules/kafka/src/test/scala/com/snowplowanalytics/snowplow/bigquery/KafkaConfigSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ object KafkaConfigSpec {
metrics = Config.Metrics(None),
sentry = None,
healthProbe = Config.HealthProbe(port = Port.fromInt(8000).get, unhealthyLatency = 5.minutes),
webhook = Webhook.Config(endpoint = None, tags = Map.empty, heartbeat = 60.minutes)
webhook = Webhook.Config(endpoint = None, tags = Map.empty, heartbeat = 5.minutes)
),
license = AcceptedLicense(),
skipSchemas = List.empty,
Expand Down
2 changes: 1 addition & 1 deletion ...es/kinesis/src/test/scala/com/snowplowanalytics/snowplow/bigquery/KinesisConfigSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ object KinesisConfigSpec {
metrics = Config.Metrics(None),
sentry = None,
healthProbe = Config.HealthProbe(port = Port.fromInt(8000).get, unhealthyLatency = 5.minutes),
webhook = Webhook.Config(endpoint = None, tags = Map.empty, heartbeat = 60.minutes)
webhook = Webhook.Config(endpoint = None, tags = Map.empty, heartbeat = 5.minutes)
),
license = AcceptedLicense(),
skipSchemas = List.empty,
Expand Down
36 changes: 19 additions & 17 deletions modules/pubsub/src/test/scala/com/snowplowanalytics/snowplow/bigquery/PubsubConfigSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,15 @@ class PubsubConfigSpec extends Specification with CatsEffect {
object PubsubConfigSpec {
private val minimalConfig = Config[PubsubSourceConfig, PubsubSinkConfig](
input = PubsubSourceConfig(
subscription = PubsubSourceConfig.Subscription("my-project", "snowplow-enriched"),
parallelPullFactor = BigDecimal(0.5),
bufferMaxBytes = 10000000,
maxAckExtensionPeriod = 1.hour,
minDurationPerAckExtension = 1.minute,
maxDurationPerAckExtension = 10.minutes,
gcpUserAgent = PubsubUserAgent("Snowplow OSS", "bigquery-loader"),
shutdownTimeout = 30.seconds
subscription = PubsubSourceConfig.Subscription("my-project", "snowplow-enriched"),
parallelPullFactor = BigDecimal(0.5),
bufferMaxBytes = 10000000,
maxAckExtensionPeriod = 1.hour,
minDurationPerAckExtension = 1.minute,
maxDurationPerAckExtension = 10.minutes,
gcpUserAgent = PubsubUserAgent("Snowplow OSS", "bigquery-loader"),
shutdownTimeout = 30.seconds,
maxPullsPerTransportChannel = 16
),
output = Config.Output(
good = Config.BigQuery(
Expand Down Expand Up @@ -116,7 +117,7 @@ object PubsubConfigSpec {
metrics = Config.Metrics(None),
sentry = None,
healthProbe = Config.HealthProbe(port = Port.fromInt(8000).get, unhealthyLatency = 5.minutes),
webhook = Webhook.Config(endpoint = None, tags = Map.empty, heartbeat = 60.minutes)
webhook = Webhook.Config(endpoint = None, tags = Map.empty, heartbeat = 5.minutes)
),
license = AcceptedLicense(),
skipSchemas = List.empty,
Expand All @@ -127,14 +128,15 @@ object PubsubConfigSpec {

private val extendedConfig = Config[PubsubSourceConfig, PubsubSinkConfig](
input = PubsubSourceConfig(
subscription = PubsubSourceConfig.Subscription("my-project", "snowplow-enriched"),
parallelPullFactor = BigDecimal(0.5),
bufferMaxBytes = 1000000,
maxAckExtensionPeriod = 1.hour,
minDurationPerAckExtension = 1.minute,
maxDurationPerAckExtension = 10.minutes,
gcpUserAgent = PubsubUserAgent("Snowplow OSS", "bigquery-loader"),
shutdownTimeout = 30.seconds
subscription = PubsubSourceConfig.Subscription("my-project", "snowplow-enriched"),
parallelPullFactor = BigDecimal(0.5),
bufferMaxBytes = 1000000,
maxAckExtensionPeriod = 1.hour,
minDurationPerAckExtension = 1.minute,
maxDurationPerAckExtension = 10.minutes,
gcpUserAgent = PubsubUserAgent("Snowplow OSS", "bigquery-loader"),
shutdownTimeout = 30.seconds,
maxPullsPerTransportChannel = 16
),
output = Config.Output(
good = Config.BigQuery(
Expand Down
2 changes: 1 addition & 1 deletion project/Dependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ object Dependencies {
val bigquery = "2.34.2"

// Snowplow
val streams = "0.8.0-M4"
val streams = "0.8.0-M6"
val igluClient = "3.1.0"

// tests
Expand Down
Loading