Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade common-streams to 0.8.0-M6 #386

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Upgrade common-streams to 0.8.0-M6 #386

merged 1 commit into from
Oct 16, 2024

Conversation

oguzhanunlu
Copy link
Contributor

@oguzhanunlu oguzhanunlu commented Oct 16, 2024

This PR brings a bug fix related to schema evolution.

The bug is applicable for rc17 only. It was introduced after common-streams 0.8.0-M2, which is why bq loader rc16 doesn't have this issue.

With rc17, if a batch of schemas, all belonging to same family, contains a schema without any properties and have additionalProperties: false, bq loader wouldn't evolve the events table as expected, not creating the corresponding fields.

Upgrading common-streams to M6 will fix this bug.

Copy link
Contributor

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Significant change to the heartbeat setting in the config specs which I'm not sure I follow 100%, but I don't see where that change would cause problems

@oguzhanunlu
Copy link
Contributor Author

thanks @colmsnowplow ! That change is coming from this commit. It isn't part of bug fix but another commit in m6.

@oguzhanunlu oguzhanunlu merged commit 28a2b91 into v2 Oct 16, 2024
2 checks passed
@oguzhanunlu oguzhanunlu deleted the streams-m6 branch October 16, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants