This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
forked from permutive-engineering/fs2-pubsub
-
Notifications
You must be signed in to change notification settings - Fork 0
Release/0.18.0 #1
Open
oguzhanunlu
wants to merge
3
commits into
release/0.17.0
Choose a base branch
from
release/0.18.0
base: release/0.17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
name: CD | ||
|
||
on: | ||
push: | ||
tags: | ||
- '*' | ||
|
||
jobs: | ||
cd: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: coursier/cache-action@v5 | ||
|
||
- name: Set up JDK 8 | ||
uses: actions/setup-java@v1 | ||
with: | ||
java-version: 8 | ||
|
||
- name: Create GitHub release & Attach artifacts | ||
uses: softprops/action-gh-release@v1 | ||
with: | ||
draft: true | ||
prerelease: ${{ contains(steps.version.outputs.tag, 'M') }} | ||
name: ${{ steps.version.outputs.tag }} | ||
tag_name: ${{ steps.version.outputs.tag }} | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Publish common_2.12 to Sonatype | ||
run: | | ||
sbt "project common" clean ci-release | ||
continue-on-error: true | ||
env: | ||
PGP_PASSPHRASE: ${{ secrets.SONA_PGP_PASSPHRASE }} | ||
PGP_SECRET: ${{ secrets.SONA_PGP_SECRET }} | ||
SONATYPE_PASSWORD: ${{ secrets.SONA_PASS }} | ||
SONATYPE_USERNAME: ${{ secrets.SONA_USER }} | ||
|
||
- name: Publish grpc_2.12 to Sonatype | ||
run: | | ||
sbt "project grpc" clean ci-release | ||
continue-on-error: true | ||
env: | ||
PGP_PASSPHRASE: ${{ secrets.SONA_PGP_PASSPHRASE }} | ||
PGP_SECRET: ${{ secrets.SONA_PGP_SECRET }} | ||
SONATYPE_PASSWORD: ${{ secrets.SONA_PASS }} | ||
SONATYPE_USERNAME: ${{ secrets.SONA_USER }} | ||
|
||
- name: Publish common_2.13 to Sonatype | ||
run: | | ||
sbt "project common" ++2.13.5! clean ci-release | ||
continue-on-error: true | ||
env: | ||
PGP_PASSPHRASE: ${{ secrets.SONA_PGP_PASSPHRASE }} | ||
PGP_SECRET: ${{ secrets.SONA_PGP_SECRET }} | ||
SONATYPE_PASSWORD: ${{ secrets.SONA_PASS }} | ||
SONATYPE_USERNAME: ${{ secrets.SONA_USER }} | ||
|
||
- name: Publish grpc_2.13 to Sonatype | ||
run: | | ||
sbt "project grpc" ++2.13.5! clean ci-release | ||
continue-on-error: true | ||
env: | ||
PGP_PASSPHRASE: ${{ secrets.SONA_PGP_PASSPHRASE }} | ||
PGP_SECRET: ${{ secrets.SONA_PGP_SECRET }} | ||
SONATYPE_PASSWORD: ${{ secrets.SONA_PASS }} | ||
SONATYPE_USERNAME: ${{ secrets.SONA_USER }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
name: CI | ||
|
||
on: | ||
push: | ||
branches: | ||
- master | ||
pull_request: | ||
|
||
jobs: | ||
ci: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: coursier/cache-action@v5 | ||
|
||
- name: Set up JDK 8 | ||
uses: actions/setup-java@v1 | ||
with: | ||
java-version: 8 | ||
|
||
- name: Run tests | ||
run: sbt "project grpc" clean +test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
name: Snyk | ||
|
||
on: | ||
push: | ||
branches: [ master ] | ||
|
||
jobs: | ||
snyk: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: coursier/cache-action@v6 | ||
|
||
- name: Run Snyk to check for vulnerabilities | ||
uses: snyk/actions/scala@master | ||
with: | ||
command: monitor | ||
args: --project-name=fs2-google-pubsub | ||
env: | ||
SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ def priorTo2_13(scalaVersion: String): Boolean = | |
} | ||
|
||
lazy val commonSettings = Seq( | ||
organization := "com.permutive", | ||
organization := "com.snowplowanalytics", | ||
scalaVersion := Dependencies.Versions.scala212, | ||
crossScalaVersions := Seq(Dependencies.Versions.scala212, Dependencies.Versions.scala213), | ||
javacOptions in (Compile, compile) ++= Seq("-source", "1.8", "-target", "1.8"), | ||
|
@@ -56,7 +56,7 @@ lazy val commonSettings = Seq( | |
"-opt-inline-from:com.permutive.**", | ||
"-opt-warnings", | ||
// Lint after expansion so that implicits used in macros are not flagged as unused | ||
"-Ywarn-macros:after", | ||
"-Ywarn-macros:after" | ||
), | ||
scalacOptions ++= { | ||
if (priorTo2_13(scalaVersion.value)) | ||
|
@@ -70,11 +70,11 @@ lazy val commonSettings = Seq( | |
"-Ywarn-nullary-unit", // Warn when nullary methods return Unit. | ||
"-Xlint:by-name-right-associative", // By-name parameter of right associative operator. | ||
"-Xlint:unsound-match", // Pattern match may not be typesafe. | ||
"-Xfuture", // Turn on future language features. | ||
"-Xfuture" // Turn on future language features. | ||
) | ||
else | ||
Seq( | ||
"-Ymacro-annotations", | ||
"-Ymacro-annotations" | ||
) | ||
} | ||
) | ||
|
@@ -85,7 +85,7 @@ lazy val common = (project in file("fs2-google-pubsub")) | |
commonSettings, | ||
publishSettings, | ||
libraryDependencies ++= Dependencies.commonDependencies, | ||
libraryDependencies ++= Dependencies.testsDependencies, | ||
libraryDependencies ++= Dependencies.testsDependencies | ||
) | ||
|
||
lazy val http = (project in file("fs2-google-pubsub-http")) | ||
|
@@ -95,7 +95,7 @@ lazy val http = (project in file("fs2-google-pubsub-http")) | |
commonSettings, | ||
publishSettings, | ||
libraryDependencies ++= Dependencies.httpDependencies, | ||
libraryDependencies ++= Dependencies.testsDependencies, | ||
libraryDependencies ++= Dependencies.testsDependencies | ||
) | ||
|
||
lazy val grpc = (project in file("fs2-google-pubsub-grpc")) | ||
|
@@ -105,7 +105,7 @@ lazy val grpc = (project in file("fs2-google-pubsub-grpc")) | |
commonSettings, | ||
publishSettings, | ||
libraryDependencies ++= Dependencies.grpcDependencies, | ||
libraryDependencies ++= Dependencies.testsDependencies, | ||
libraryDependencies ++= Dependencies.testsDependencies | ||
) | ||
|
||
lazy val root = (project in file(".")) | ||
|
@@ -115,42 +115,28 @@ lazy val root = (project in file(".")) | |
commonSettings, | ||
publishSettings, | ||
publish / skip := true, | ||
crossScalaVersions := Nil | ||
) | ||
.aggregate( | ||
common, | ||
http, | ||
grpc | ||
) | ||
|
||
lazy val publishSettings = Seq( | ||
releaseCrossBuild := true, | ||
releaseVcsSign := true, | ||
releasePublishArtifactsAction := PgpKeys.publishSigned.value, | ||
homepage := Some(url("https://github.com/permutive/fs2-google-pubsub")), | ||
licenses := Seq("Apache 2.0" -> url("http://www.apache.org/licenses/LICENSE-2.0")), | ||
publishMavenStyle := true, | ||
publishArtifact in Test := false, | ||
pomIncludeRepository := { _ => | ||
false | ||
}, | ||
publishTo := { | ||
val nexus = "https://oss.sonatype.org/" | ||
if (isSnapshot.value) | ||
Some("snapshots".at(nexus + "content/repositories/snapshots")) | ||
else | ||
Some("releases".at(nexus + "service/local/staging/deploy/maven2")) | ||
}, | ||
autoAPIMappings := true, | ||
scmInfo := Some( | ||
ScmInfo( | ||
url("https://github.com/permutive/fs2-google-pubsub"), | ||
"scm:git:[email protected]:permutive/fs2-google-pubsub.git" | ||
) | ||
), | ||
lazy val publishSettings = Seq[Setting[_]]( | ||
publishArtifact := true, | ||
pomIncludeRepository := { _ => false }, | ||
ThisBuild / dynverVTagPrefix := false, // Otherwise git tags required to have v-prefix | ||
organization := "com.snowplowanalytics", | ||
homepage := Some(url("https://snowplowanalytics.com")), | ||
licenses := List("Apache-2.0" -> url("http://www.apache.org/licenses/LICENSE-2.0")), | ||
scmInfo := Some(ScmInfo(url("https://github.com/snowplow-incubator/fs2-google-pubsub"), "scm:[email protected]:snowplow-incubator/fs2-google-pubsub.git")), | ||
Test / publishArtifact := false, | ||
developers := List( | ||
Developer("cremboc", "Paulius Imbrasas", "", url("https://github.com/cremboc")), | ||
Developer("TimWSpence", "Tim Spence", "", url("https://github.com/TimWSpence")), | ||
Developer("bastewart", "Ben Stewart", "", url("https://github.com/bastewart")), | ||
Developer("travisbrown", "Travis Brown", "", url("https://twitter.com/travisbrown")) | ||
Developer("travisbrown", "Travis Brown", "", url("https://twitter.com/travisbrown")), | ||
Developer("Snowplow Analytics Ltd", "Snowplow Analytics Ltd", "[email protected]", url("https://snowplowanalytics.com")) | ||
) | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
sbt.version=1.3.13 | ||
sbt.version=1.5.5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we cannot remove that? It looks like we re-attribute the whole code to us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I think we can add ourselves to the list, but we shouldn't remove the existing developers.
It's probably also worth mentioning in the README that this is a fork and pointing to the original repository for anyone who finds this (and I'd make it quite prominent), that just feels like the right thing to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks both, I’ll add us instead of replacing and update README as well