This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
Release/0.18.0 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzhanunlu
force-pushed
the
release/0.18.0
branch
3 times, most recently
from
ab607ba to
01b5177
Compare
oguzhanunlu
force-pushed
the
release/0.18.0
branch
3 times, most recently
from
ec30f57 to
05ecedc
Compare
chuwy
approved these changes
Aug 12, 2021
| developers := List( | ||
| Developer("cremboc", "Paulius Imbrasas", "", url("https://github.com/cremboc")), |
There was a problem hiding this comment.
I think we cannot remove that? It looks like we re-attribute the whole code to us?
There was a problem hiding this comment.
I agree. I think we can add ourselves to the list, but we shouldn't remove the existing developers.
It's probably also worth mentioning in the README that this is a fork and pointing to the original repository for anyone who finds this (and I'd make it quite prominent), that just feels like the right thing to do.
There was a problem hiding this comment.
thanks both, I’ll add us instead of replacing and update README as well
oguzhanunlu
force-pushed
the
release/0.18.0
branch
from
05ecedc to
94879b0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created
0.17.0branch based on v0.17.0 tag which is the last tag before cats-effect 3 upgrade in the original repo. I added CI/CD migration and cherry-picked Ian's commit on top.I tested Ian's work last week on enrich-pubsub successfully.