Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-698916 support Python 3.11 #1349

Merged
merged 11 commits into from
Jan 25, 2023

Conversation

noamcohen97
Copy link
Contributor

@noamcohen97 noamcohen97 commented Nov 25, 2022

@github-actions
Copy link

github-actions bot commented Nov 25, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@noamcohen97
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@3dbrows 3dbrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some commit suggestions for the libarrow_dataset library which appears to be necessary with Arrow 10.

Co-authored-by: Duncan MacQuarrie <[email protected]>
@potiuk
Copy link
Contributor

potiuk commented Nov 25, 2022

🤞

@idanmiara
Copy link

Thanks @noamcohen97
I can confirm that it builds and installs locally on Python 3.11 on macos.

@noamcohen97
Copy link
Contributor Author

@sfc-gh-mkeller Can you please have a look?

Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the team:

  • We'll need to update manylinux2014_x86_64 docker images on our internal mirror ✅
  • We need to setup Python 3.11 on Mac and Windows Jenkins workers and seed the new 3.11 jobs ✅
  • Generate new Jenkins test jobs ✅
  • Probably update gosu versions in the Dockerfiles ✅

Otherwise I think the PR itself looks good!
@noamcohen97 would you mind bumping the gosu version to the newest one in your PR too?

setup.py Outdated Show resolved Hide resolved
@sfc-gh-mkeller sfc-gh-mkeller self-assigned this Dec 1, 2022
@noamcohen97
Copy link
Contributor Author

Thanks for reviewing @sfc-gh-mkeller!

would you mind bumping the gosu version to the newest one in your PR too

Sure! Will do.

Also, would you mind approving the workflows so build and tests will run?

@noamcohen97
Copy link
Contributor Author

BTW, would you like me to add an entry to the release notes?

@noamcohen97
Copy link
Contributor Author

@sfc-gh-mkeller any updates on this?

@dataders
Copy link
Contributor

dataders commented Dec 14, 2022

hi @sfc-gh-aling and @sfc-gh-mkeller sorry to "at" you here, but we're blocked on dbt-labs/dbt-snowflake#336 which is needed for the next minor version of dbt-core and dbt-snowflake. 👀 @colin-rogers-dbt

@sfc-gh-mkeller
Copy link
Collaborator

BTW, would you like me to add an entry to the release notes?

Yes, absolutely!

@sfc-gh-mkeller any updates on this?

We're currently blocked on our Windows and Mac Jenkins workers having Python 3.11 installed. We have completed the rest of the steps necessary to merge this. That being said our target to release Python 3.11 support is in the January release.

@3dbrows
Copy link
Contributor

3dbrows commented Dec 14, 2022

@sfc-gh-mkeller Any chance of merging #1336 in the meantime, which upgrades PyArrow, but not Python? This might also be of some interest to @dataders .

The advantage would be that it would raise the version ceiling on PyArrow in any projects which use the Snowflake connector.

@noamcohen97
Copy link
Contributor Author

our target to release Python 3.11 support is in the January release.

@sfc-gh-mkeller Sounds great! looking forward for it

@sfc-gh-mkeller
Copy link
Collaborator

pyarrow==10.0.1 support was merged through #1347
This PR will need to be rebased

@noamcohen97
Copy link
Contributor Author

BTW, would you like me to add an entry to the release notes?

Yes, absolutely!

Done!

@Yarden-zamir
Copy link

Hi, whatsup with this? I really would love to have 3.11

@yogevyuval
Copy link

@sfc-gh-mkeller Hi! Any news regarding this? We would love to test python 3.11

@Yarden-zamir
Copy link

Yarden-zamir commented Jan 18, 2023

Note for people who need this but are not patient, you can use the branch of this pr in your requirements / pip install like so

git+https://github.com/noamcohen97/snowflake-connector-python.git@feature/3.11

This was referenced Jan 24, 2023
@sfc-gh-mkeller sfc-gh-mkeller changed the title SNOW-698916 : Bump PyArrow version to support Python 3.11 SNOW-698916 support Python 3.11 Jan 24, 2023
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-mkeller sfc-gh-mkeller merged commit c08ba70 into snowflakedb:main Jan 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
@noamcohen97 noamcohen97 deleted the feature/3.11 branch January 25, 2023 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-698916: Pyarrow 8 is not compatible with Python 3.11
9 participants