-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-698916 support Python 3.11 #1349
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some commit suggestions for the libarrow_dataset
library which appears to be necessary with Arrow 10.
Co-authored-by: Duncan MacQuarrie <[email protected]>
🤞 |
Thanks @noamcohen97 |
@sfc-gh-mkeller Can you please have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for the team:
- We'll need to update manylinux2014_x86_64 docker images on our internal mirror ✅
- We need to setup Python 3.11 on Mac and Windows Jenkins workers and seed the new 3.11 jobs ✅
- Generate new Jenkins test jobs ✅
- Probably update
gosu
versions in the Dockerfiles ✅
Otherwise I think the PR itself looks good!
@noamcohen97 would you mind bumping the gosu
version to the newest one in your PR too?
Thanks for reviewing @sfc-gh-mkeller!
Sure! Will do. Also, would you mind approving the workflows so build and tests will run? |
BTW, would you like me to add an entry to the release notes? |
@sfc-gh-mkeller any updates on this? |
hi @sfc-gh-aling and @sfc-gh-mkeller sorry to "at" you here, but we're blocked on dbt-labs/dbt-snowflake#336 which is needed for the next minor version of dbt-core and dbt-snowflake. 👀 @colin-rogers-dbt |
Yes, absolutely!
We're currently blocked on our Windows and Mac Jenkins workers having Python 3.11 installed. We have completed the rest of the steps necessary to merge this. That being said our target to release Python 3.11 support is in the January release. |
@sfc-gh-mkeller Any chance of merging #1336 in the meantime, which upgrades PyArrow, but not Python? This might also be of some interest to @dataders . The advantage would be that it would raise the version ceiling on PyArrow in any projects which use the Snowflake connector. |
@sfc-gh-mkeller Sounds great! looking forward for it |
|
Done! |
Hi, whatsup with this? I really would love to have 3.11 |
@sfc-gh-mkeller Hi! Any news regarding this? We would love to test python 3.11 |
Note for people who need this but are not patient, you can use the branch of this pr in your requirements / pip install like so
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢
Fixes #1345
@sfc-gh-aling