Test 1336 #1347
Merged
Test 1336 #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
checkout #1349 |
|
@sfc-gh-mkeller , #1336 is updated now and should build fine, but @noamcohen97 's #1349 does this and adds Python 3.11 support. |
sfc-gh-mkeller
force-pushed
the
test_pr_1336
branch
from
0de9355 to
483fded
Compare
|
I've pushed a fix for the linting error to #1336 , @sfc-gh-mkeller |
sfc-gh-mkeller
force-pushed
the
test_pr_1336
branch
3 times, most recently
from
0f2173d to
5f68866
Compare
sfc-gh-mkeller
commented
Jan 6, 2023
Comment on lines
+151
to
+152
| if not any("/std" not in s for s in ext.extra_compile_args): | ||
| ext.extra_compile_args.append("/std:c++17") |
There was a problem hiding this comment.
Yes, Arrow 10 switched to C++17 as the minimal supported C++ standard.
Updates the requirements on [pyarrow](https://github.com/apache/arrow) to permit the latest version. - [Release notes](https://github.com/apache/arrow/releases) - [Commits](apache/arrow@go/v8.0.0...go/v10.0.0) --- updated-dependencies: - dependency-name: pyarrow dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Noam Cohen (noamcohen97) <[email protected]>
Co-authored-by: Noam Cohen (noamcohen97) <[email protected]>
sfc-gh-mkeller
force-pushed
the
test_pr_1336
branch
from
5f68866 to
794ce59
Compare
Codecov Report
@@ Coverage Diff @@
## main #1347 +/- ##
==========================================
- Coverage 81.28% 81.25% -0.04%
==========================================
Files 61 61
Lines 8556 8556
Branches 1262 1262
==========================================
- Hits 6955 6952 -3
- Misses 1283 1285 +2
- Partials 318 319 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DESCRIPTION.md
Outdated
Comment on lines
48
to
49
| - Enhanced the atomicity of write_pandas when overwrite is set to True | ||
| - Bumped pyarrow dependency from >=8.0.0,<8.1.0 to >=10.0.0,<10.1.0 |
There was a problem hiding this comment.
those two should be moved under 2.9.1?
sfc-gh-aling
approved these changes
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests #1336