feat: Remove LogGroups and export table on stack deletion #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopher-watanabe-snkeos
deleted the
feature/delete-log-groups-and-export-table
branch
christopher-watanabe-snkeos
added a commit
that referenced
this pull request
Jul 8, 2024
* feat: Update fwoa-utilities to snke source * feat: Replace deployment with snke source (#6) * feat: Replace routing code with snke source (#5) * feat: Replace persistence-ddb with snke source (#4) * feat: Replace authz-rbac code with snke source (#3) * feat: Replace interface code with snke source (#2) * feat: Remove KMS keys on stack deletion (#8) * feat: Remove LogGroups and export table on stack deletion (#9) * feat: Empty S3 bucand delete s3 buckets on stack deletion * feat: Remove export request table and bulk export results bucket smart deployment * feat: Remove versioning from s3 buckets * fix: Add NAG suppression to disable versioning of buckets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serverless solution also removed these resources on stack deletion. If we don't, then redeployment of FHIRworks to an account / region where FHIRworks was removed fails because these Resources already exist.