Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace persistence-ddb with snke source #4

Merged

Conversation

christopher-watanabe-snkeos
Copy link
Collaborator

@christopher-watanabe-snkeos christopher-watanabe-snkeos commented Jul 2, 2024

Contributes to https://github.com/snkeos/hcp-product-backlog/issues/965 by merging snke source to the fhir-works-on-aws-persistence-ddb.

List of meaningful changes:

  • Deleted items are removed from DDB table (not just updated to not available and kept in the table)
  • Hybrid database store, wherein large payloads are split (example: item fields for QuestionnaireResponses are stored in S3 while the stripped down resource is kept in the DDB table)

The code introduced in this PR is a mirror of the state of the snkeos-main branch of the fhir-works-on-aws-persistence-ddb repo: https://github.com/snkeos/fhir-works-on-aws-persistence-ddb/tree/snkeos-main.

The source has been fully overwritten by the state of the snkeos-main branch, on account of deployment difficulties when merging aws-solutions changes. This will be taken up in a later task, if deemed necessary. The primary features introduced by aws-solutions include:

  • increasing bundle limit to 100 instead of 25
    • currently bundle upload must anyway be updated, as changes to persistence on a resource basis were not undertaken for bundles
  • configuration for upsert

@christopher-watanabe-snkeos christopher-watanabe-snkeos changed the title feat: Merge snke source changes to aws-solutions main feat: Merge snke persistence-ddb changes to AWS solutions persistence Jul 2, 2024
@christopher-watanabe-snkeos christopher-watanabe-snkeos changed the base branch from main to feature/snke-source July 2, 2024 12:18
@christopher-watanabe-snkeos christopher-watanabe-snkeos changed the title feat: Merge snke persistence-ddb changes to AWS solutions persistence feat: Replace persistence-ddb with snke source Jul 2, 2024
@christopher-watanabe-snkeos christopher-watanabe-snkeos requested a review from a team July 3, 2024 07:01
@christopher-watanabe-snkeos christopher-watanabe-snkeos merged commit 0956e2c into feature/snke-source Jul 3, 2024
@christopher-watanabe-snkeos christopher-watanabe-snkeos deleted the feature/snke-persistence branch July 3, 2024 13:03
christopher-watanabe-snkeos added a commit that referenced this pull request Jul 8, 2024
* feat: Update fwoa-utilities to snke source

* feat: Replace deployment with snke source (#6)

* feat: Replace routing code with snke source (#5)

* feat: Replace persistence-ddb with snke source (#4)

* feat: Replace authz-rbac code with snke source (#3)

* feat: Replace interface code with snke source (#2)

* feat: Remove KMS keys on stack deletion (#8)

* feat: Remove LogGroups and export table on stack deletion (#9)

* feat: Empty S3 bucand delete s3 buckets on stack deletion

* feat: Remove export request table and bulk export results bucket smart deployment

* feat: Remove versioning from s3 buckets

* fix: Add NAG suppression to disable versioning of buckets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants