Skip to content

Commit

Permalink
Make EuiTableRowCell textOnly={false} when its an expanded row (elast…
Browse files Browse the repository at this point in the history
…ic#2376)

* Make EuiTableRowCell textOnly={false} when its an expanded row

* changelog
  • Loading branch information
chandlerprall authored and snide committed Oct 10, 2019
1 parent 0677875 commit 3db78cc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- Added a `showMaxPopover` option for `EuiBreadcrumbs` to display all items when a `max` is set. ([#2342](https://github.com/elastic/eui/pull/2342))
- Added `data-test-subj` support for basic and in-memory tables' actions ([#2353](https://github.com/elastic/eui/pull/2353))
- Added `ip` icon to glyph set ([#2371](https://github.com/elastic/eui/pull/2371))
- Set `textOnly={true}` for expanded rows in `EuiBasicTable` ([#2376](https://github.com/elastic/eui/pull/2376))

**Bug fixes**

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1040,6 +1040,7 @@ exports[`EuiBasicTable itemIdToExpandedRowMap renders an expanded row 1`] = `
>
<EuiTableRowCell
colSpan={1}
textOnly={false}
>
<div>
Expanded row
Expand Down
2 changes: 1 addition & 1 deletion src/components/basic_table/basic_table.js
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ export class EuiBasicTable extends Component {
id={expandedRowId}
isExpandedRow={true}
isSelectable={isSelectable}>
<EuiTableRowCell colSpan={expandedRowColSpan}>
<EuiTableRowCell colSpan={expandedRowColSpan} textOnly={false}>
{itemIdToExpandedRowMap[itemId]}
</EuiTableRowCell>
</EuiTableRow>
Expand Down

0 comments on commit 3db78cc

Please sign in to comment.