Skip to content

Commit

Permalink
use euiFocusBackgroundColor for EuiFacetButton :focus (elastic#2365)
Browse files Browse the repository at this point in the history
* use  for EuiFacetButton :focus

* Updated changelog

* removed trailing whitespace

* fixed indentation

* fixed my mistake / leftover code

* use euiSizeXS instead of px value
  • Loading branch information
hbharding authored and snide committed Oct 10, 2019
1 parent 019c33b commit 0677875
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Modified `EuiFacetButton` to use `$euiFocusBackgroundColor` for `:focus` state ([2365](https://github.com/elastic/eui/pull/2365))
- Added a `showMaxPopover` option for `EuiBreadcrumbs` to display all items when a `max` is set. ([#2342](https://github.com/elastic/eui/pull/2342))
- Added `data-test-subj` support for basic and in-memory tables' actions ([#2353](https://github.com/elastic/eui/pull/2353))
- Added `ip` icon to glyph set ([#2371](https://github.com/elastic/eui/pull/2371))
Expand Down
4 changes: 3 additions & 1 deletion src/components/facet/_facet_button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
}

&:focus {
background-color: $euiColorLightestShade;
background-color: $euiFocusBackgroundColor;
// use box-shadow as a "faux outline" to apply left/right padding only
box-shadow: -$euiSizeXS 0 $euiFocusBackgroundColor, $euiSizeXS 0 $euiFocusBackgroundColor;
}

&:disabled {
Expand Down

0 comments on commit 0677875

Please sign in to comment.