Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#313 solved serializers casting problems using SpecificDatumWriter #315

Merged
merged 14 commits into from
Dec 19, 2022
Merged

#313 solved serializers casting problems using SpecificDatumWriter #315

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
00c6a76
303 docker compose for securing kafka first attempt
davidgarciago Nov 14, 2022
ff75289
303 changed docker compose SSL to PLAINTEXT
davidgarciago Nov 14, 2022
de398ad
#303 kafka Auth Configuration
Nov 14, 2022
aef053c
#303 added user for producer to connect to kafka
davidgarciago Nov 15, 2022
a10d832
#313 solved serializers casting problems using SpecificDatumWritter
davidgarciago Dec 1, 2022
ea09ff2
#313 removed unused asignment to DatumWriter
davidgarciago Dec 1, 2022
7a92079
#313 updated pom.xml
davidgarciago Dec 2, 2022
62959b5
Merge branch '303-issue-escaping-with-bar-failing-jaas-auth' of githu…
davidgarciago Dec 2, 2022
2de97e9
#313 datum writer changed to final
davidgarciago Dec 5, 2022
3064978
#313 added new test for serializers with logicaltypes and removed unu…
davidgarciago Dec 15, 2022
9ebb938
#313 Solving checkstyle problems
davidgarciago Dec 15, 2022
9ea2f92
#313 moving avro logical types conversion config to avro serializers
davidgarciago Dec 15, 2022
20ab0fe
#313 checkstyle errors fix
davidgarciago Dec 15, 2022
8ee9b31
#313 changed incorrect pom version
davidgarciago Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/net/coru/kloadgen/serializer/GenericAvroRecordBinarySerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,12 @@
import java.io.IOException;

import lombok.extern.slf4j.Slf4j;
import org.apache.avro.generic.GenericDatumWriter;
import org.apache.avro.generic.GenericRecord;
import org.apache.avro.io.DatumWriter;
import org.apache.avro.io.EncoderFactory;
import org.apache.avro.specific.SpecificDatumWriter;
import org.apache.avro.specific.SpecificRecord;
import org.apache.kafka.common.header.Headers;
import org.apache.kafka.common.serialization.Serializer;

Expand All @@ -21,7 +24,12 @@ public class GenericAvroRecordBinarySerializer<T extends GenericRecord> implemen

@Override
public final byte[] serialize(final String s, final T data) {
final var writer = new SpecificDatumWriter<>(data.getSchema());
DatumWriter<T> writer = new GenericDatumWriter<>(data.getSchema());
if (data instanceof SpecificRecord) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test

writer = new SpecificDatumWriter<>(data.getSchema());
} else {
writer = new GenericDatumWriter<>(data.getSchema());
}
var result = new byte[]{};
try (final ByteArrayOutputStream baos = new ByteArrayOutputStream()) {
final var encoder = EncoderFactory.get().binaryEncoder(baos, null);
Expand Down
11 changes: 10 additions & 1 deletion src/main/java/net/coru/kloadgen/serializer/GenericAvroRecordSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@
import java.io.IOException;

import lombok.extern.slf4j.Slf4j;
import org.apache.avro.generic.GenericDatumWriter;
import org.apache.avro.generic.GenericRecord;
import org.apache.avro.io.DatumWriter;
import org.apache.avro.io.Encoder;
import org.apache.avro.io.EncoderFactory;
import org.apache.avro.specific.SpecificDatumWriter;
import org.apache.avro.specific.SpecificRecord;
import org.apache.kafka.common.header.Headers;
import org.apache.kafka.common.serialization.Serializer;

Expand All @@ -23,7 +26,13 @@ public class GenericAvroRecordSerializer<T extends GenericRecord> implements Ser
@Override
public final byte[] serialize(final String topic, final T data) {

final var writer = new SpecificDatumWriter<>(data.getSchema());
DatumWriter<T> writer = new GenericDatumWriter<>(data.getSchema());
if (data instanceof SpecificRecord) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test

writer = new SpecificDatumWriter<>(data.getSchema());
} else {
writer = new GenericDatumWriter<>(data.getSchema());
}

byte[] dataBytes = new byte[0];
final var stream = new ByteArrayOutputStream();
final Encoder jsonEncoder;
Expand Down