#313 solved serializers casting problems using SpecificDatumWriter #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgarciago
requested review from
jemacineiras,
pedror19,
dianaGomezGar,
mseijasm and
RaulBejaranoSngular
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
RaulBejaranoSngular
previously approved these changes
Dec 1, 2022
pedror19
previously approved these changes
Dec 1, 2022
dianaGomezGar
requested changes
Dec 1, 2022
jemacineiras
requested changes
Dec 1, 2022
davidgarciago
dismissed stale reviews from pedror19 and RaulBejaranoSngular
via
7a92079
…b.com:corunet/kloadgen into 313-issue-long-timestamp-millis-trouble-to-cast
|
I have added a new docker file from the #303 issue branch. I think it can be usefull to test the plugin. |
dianaGomezGar
previously approved these changes
Dec 5, 2022
|
All changes requested have been committed. Please @jemacineiras review them when you have time. |
…sed specific datum writer in serializers
|
I have added new tests for the serializers. I also removed the use of SpecificDatumWritter from both serializers affected by the issue because it was never used. The reason of this was that serializers data was always of type GenericRecord and not SpecificRecord. |
davidgarciago
requested review from
jemacineiras,
pedror19,
dianaGomezGar and
RaulBejaranoSngular
pedror19
approved these changes
Dec 16, 2022
jemacineiras
approved these changes
Dec 19, 2022
| @@ -21,7 +24,12 @@ | |||
|
|
|||
| @Override | |||
| public final byte[] serialize(final String s, final T data) { | |||
| final var writer = new SpecificDatumWriter<>(data.getSchema()); | |||
| DatumWriter<T> writer; | |||
| if (data instanceof SpecificRecord) { | |||
| @@ -23,7 +26,13 @@ | |||
| @Override | |||
| public final byte[] serialize(final String topic, final T data) { | |||
|
|
|||
| final var writer = new SpecificDatumWriter<>(data.getSchema()); | |||
| DatumWriter<T> writer; | |||
| if (data instanceof SpecificRecord) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The casting problem of long_timestamp-millis gets solved when using the GenericDatumWriter. Despite the lack of documentation it seems that we should use SpecificDatumWriter only when needed.