New option to move used clips to the top of the stack

As a preliminary feature to avoid clippings rolling out of use (before
adding a full "favorites" or "pinned" set of options), we add the
option to move clippings to the top of the stack when selected (either
via the menu or via keyboard).

Github issues #57, #92

Jumpcut/Jumpcut/Clippings.swift

@@ -108,6 +108,10 @@ public class ClippingStack: NSObject {
         return store.itemAt(position: position)
     }
 
+    func moveItemToTop(position: Int) {
+        store.moveItemToTop(position: position)
+    }
+
     func up() {
         let newPosition = position - 1
         if newPosition >= 0 {
@@ -237,6 +241,20 @@ private class ClippingStore: NSObject {
         writeClippings()
     }
 
+    func moveItemToTop(position: Int) {
+        // Don't move from an invalid position; also, position 0
+        // is a null operation, because it's already at the top.
+        guard !clippings.isEmpty,
+            position <= clippings.count,
+            position > 0
+        else {
+            return
+        }
+        let element = clippings.remove(at: position)
+        clippings.insert(element, at: 0)
+        writeClippings()
+    }
+
     func itemAt(position: Int) -> Clipping? {
         if clippings.isEmpty || position > clippings.count {
             return nil

Jumpcut/Jumpcut/Interactions.swift

@@ -101,6 +101,14 @@ public class Interactions: NSObject {
         } else {
             place(clipping!)
         }
+        let moveToTop = UserDefaults.standard.value(
+            forKey: SettingsPath.moveClippingsAfterUse.rawValue
+        ) as? Bool ?? false
+        if moveToTop {
+            stack.moveItemToTop(position: stack.position)
+            stack.position = 0
+            menu.rebuild(stack: stack)
+        }
     }
 
     private func handleBezelNumber(numberKey: SauceKey) {
@@ -230,6 +238,18 @@ public class Interactions: NSObject {
         } else {
             place(clipping!)
         }
+        let moveToTop = UserDefaults.standard.value(
+            forKey: SettingsPath.moveClippingsAfterUse.rawValue
+        ) as? Bool ?? false
+        if moveToTop {
+            stack.moveItemToTop(position: idx)
+            if idx == stack.position {
+                stack.position = 0
+            } else if idx > stack.position {
+                stack.position += 1
+            }
+            menu.rebuild(stack: stack)
+        }
     }
 
     @objc public func menuSelection(sender: NSMenuItem!) {

Jumpcut/Jumpcut/Preferences/ClippingsPreferenceViewController.swift

@@ -42,10 +42,14 @@ final class ClippingsPreferenceViewController: NSViewController, PreferencePane
             title: "Allow whitespace clippings",
             key: SettingsPath.allowWhitespaceClippings
         )
+        let btn5 = settings.checkbox(
+            title: "Move clippings to top after use",
+            key: SettingsPath.moveClippingsAfterUse
+        )
         skipSaveButton!.state = UserDefaults.standard.value(
             forKey: SettingsPath.skipSave.rawValue
         ) as? Bool ?? false ? .on : .off
-        let grid = NSStackView(views: [ btn1, btn2, skipSaveButton!, btn4 ])
+        let grid = NSStackView(views: [ btn1, btn2, skipSaveButton!, btn4, btn5 ])
         grid.orientation = .vertical
         grid.alignment = .leading
         self.view.addSubview(grid)

Jumpcut/Jumpcut/Settings.swift

@@ -30,8 +30,8 @@ enum SettingsPath: String {
     case mainHotkey
     case menuBehaviorFlags
     case menuIcon
-    case menuSelectionMovesToTop
     case menuSelectionPastes
+    case moveClippingsAfterUse
     case rememberNum
     case skipSave
     case stickyBezel
@@ -73,8 +73,8 @@ private let settingsDefaults: [String: Any] = [
         "modifierFlags": 786432
     ],
     SettingsPath.menuBehaviorFlags.rawValue: MenuBehaviorFlags.none.rawValue,
-    SettingsPath.menuSelectionMovesToTop.rawValue: false, // TODO: still meaningful?
     SettingsPath.menuSelectionPastes.rawValue: true,
+    SettingsPath.moveClippingsAfterUse.rawValue: false,
     SettingsPath.menuIcon.rawValue: 0,
     SettingsPath.rememberNum.rawValue: 99,
     SettingsPath.skipSave.rawValue: false,