refactor: trigger data refresher manually #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
=========================================
- Coverage 2.43% 2.42% -0.01%
=========================================
Files 39 39
Lines 2014 2017 +3
Branches 37 37
=========================================
Hits 49 49
- Misses 1928 1931 +3
Partials 37 37
☔ View full report in Codecov by Sentry. |
ChaituVR
reviewed
Oct 28, 2023
src/api.ts
Outdated
| import { name, version } from '../package.json'; | ||
| import { sendError } from './helpers/utils'; | ||
|
|
||
| const router = express.Router(); | ||
| const network = process.env.NETWORK || 'testnet'; | ||
| const SEQUENCER_URL = process.env.SEQUENCER_URL || ''; | ||
|
|
||
| refreshSpacesCache(); |
There was a problem hiding this comment.
Why this one here and refreshModerationData in index.ts 😅 better to keep all in one place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #712
Trigger the space and moderation data refresher manually, instead of automatically on import.
This allow skipping the refresh, and is particularly useful on test suite