-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter votes by choice #712
Open
wa0x6e
wants to merge
9
commits into
master
Choose a base branch
from
add-choice_in-to-vote-where
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #712 +/- ##
===========================================
+ Coverage 2.40% 16.84% +14.44%
===========================================
Files 39 39
Lines 2037 2048 +11
Branches 37 75 +38
===========================================
+ Hits 49 345 +296
+ Misses 1951 1671 -280
+ Partials 37 32 -5
☔ View full report in Codecov by Sentry. |
ChaituVR
reviewed
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another implementation of #571
Add
choice_in
filter to Vote, allowing query such asOther changes
Notes
It is impossible to add an INDEX on the choice JSON column, as the stored data format is not consistent, and can be either an INT, an array of INT, or an Object.
The filter should ideally be used only along some other filter, such as proposal id, etc ... to filter down the results first