Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from symlink to PATH in example #9

Closed
wants to merge 7 commits into from
Closed

Switch from symlink to PATH in example #9

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9afda2d
Switch from symlink to PATH in example
ddelange Mar 24, 2022
18ba87a
Update README.md
mosquito Mar 24, 2022
f3f4426
Merge branch 'snakepacker:master' into patch-1
ddelange Mar 24, 2022
95e6cfa
Skip login when there's no need to push
ddelange Mar 24, 2022
2ed22ce
Skip login when there's no need to push
ddelange Mar 24, 2022
3f3b36b
Skip login when there's no need to push
ddelange Mar 24, 2022
ad57fad
Don't pull, use gha cache
ddelange Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,15 @@ jobs:
uses: docker/setup-buildx-action@v1

- name: Login to GitHub Container Registry
if: ${{ github.ref == 'refs/heads/master' }}
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.CR_PAT }}

- name: Login to hub.docker.io Container Registry
if: ${{ github.ref == 'refs/heads/master' }}
uses: docker/login-action@v1
with:
username: mosquito
Expand Down Expand Up @@ -91,13 +93,15 @@ jobs:
uses: docker/setup-buildx-action@v1

- name: Login to GitHub Container Registry
if: ${{ github.ref == 'refs/heads/master' }}
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.CR_PAT }}

- name: Login to hub.docker.io Container Registry
if: ${{ github.ref == 'refs/heads/master' }}
uses: docker/login-action@v1
with:
username: mosquito
Expand Down Expand Up @@ -149,13 +153,15 @@ jobs:
uses: docker/setup-buildx-action@v1

- name: Login to GitHub Container Registry
if: ${{ github.ref == 'refs/heads/master' }}
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.CR_PAT }}

- name: Login to hub.docker.io Container Registry
if: ${{ github.ref == 'refs/heads/master' }}
uses: docker/login-action@v1
with:
username: mosquito
Expand Down Expand Up @@ -207,13 +213,15 @@ jobs:
uses: docker/setup-buildx-action@v1

- name: Login to GitHub Container Registry
if: ${{ github.ref == 'refs/heads/master' }}
uses: docker/login-action@v1
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.CR_PAT }}

- name: Login to hub.docker.io Container Registry
if: ${{ github.ref == 'refs/heads/master' }}
uses: docker/login-action@v1
with:
username: mosquito
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ COPY --from=builder /usr/share/python3/app /usr/share/python3/app
# Install the required library packages
RUN xargs -ra /usr/share/python3/app/pkgdeps.txt apt-install

# Create a symlink to the target binary (just for convenience)
RUN ln -snf /usr/share/python3/app/bin/ipython /usr/bin/
# Add entrypoints from the venv to PATH (e.g. 'pip', 'python', just for convenience)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Add entrypoints from the venv to PATH (e.g. 'pip', 'python', just for convenience)
# For convenience, add entrypoints from the venv to PATH, e.g. 'pip', 'python' (on py2 /usr/bin/python comes first)

ENV PATH="${PATH}:/usr/share/python3/app/bin"

CMD ["ipython"]
```
Expand Down