Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from symlink to PATH in example #9

Closed
wants to merge 7 commits into from

Conversation

ddelange
Copy link
Contributor

Hi 👋

Let me know what you think :)

$ which python
/usr/share/python3/app/bin/python

README.md Outdated Show resolved Hide resolved
@mosquito
Copy link
Contributor

@dudelange thank you for a question, really like this format the PR instead of issues ;-)

I answered in the code comments what am I think about it.

@ddelange
Copy link
Contributor Author

Hmm, CI fails due to missing credentials 🤔

Inconsistent with python2 behaviour

Agreed, is it a problem? Should we note it in that comment and go ahead with this PR? Or close it and keep the softlink?

@@ -114,8 +114,8 @@ COPY --from=builder /usr/share/python3/app /usr/share/python3/app
# Install the required library packages
RUN xargs -ra /usr/share/python3/app/pkgdeps.txt apt-install

# Create a symlink to the target binary (just for convenience)
RUN ln -snf /usr/share/python3/app/bin/ipython /usr/bin/
# Add entrypoints from the venv to PATH (e.g. 'pip', 'python', just for convenience)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Add entrypoints from the venv to PATH (e.g. 'pip', 'python', just for convenience)
# For convenience, add entrypoints from the venv to PATH, e.g. 'pip', 'python' (on py2 /usr/bin/python comes first)

@ddelange
Copy link
Contributor Author

hmm, the above changes won't work. both the push and pull are needed (always building upon latest). the alternative isn't very clean... docker/build-push-action#225 (comment)

@ddelange
Copy link
Contributor Author

Solution would probably be to pass the default available gh token to the docker login action for ghcr (docs): password: ${{ secrets.GITHUB_TOKEN }} but that doesn't solve the issue of pulling latest regardless of branch...

Would say it's a separate project to get CI to run for PRs, and due to the inconsistency with python2, will close this PR.

@ddelange ddelange closed this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants