Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a timing issue in the waiters retry delay calculation #2259

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix a timing issue in the waiters retry delay calculation #2259

merged 1 commit into from
May 2, 2024

Commits on Apr 25, 2024

  1. Fix a timing issue in the waiters retry delay calculation 

    Subtracting `minDelay` from `remainingTime` results in the waiter
exiting before the user's desired max wait time. This is especially
apparent in models that use a `minDelay` value that is larger than the
default 2 seconds. For example, AWS EC2 uses 15 seconds, so it would
exit the waiter a full 15 seconds before the desired max wait time.
    @jdisanti
    jdisanti committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    33813d8 View commit details
    Browse the repository at this point in the history