Fix a timing issue in the waiters retry delay calculation #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subtracting `minDelay` from `remainingTime` results in the waiter exiting before the user's desired max wait time. This is especially apparent in models that use a `minDelay` value that is larger than the default 2 seconds. For example, AWS EC2 uses 15 seconds, so it would exit the waiter a full 15 seconds before the desired max wait time.
sugmanue
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Subtracting
minDelayfromremainingTimeresults in the waiter exiting before the user's desired max wait time. This is especially apparent in models that use aminDelayvalue that is larger than the default 2 seconds. For example, AWS EC2 uses 15 seconds, so it would exit the waiter a full 15 seconds before the desired max wait time.Testing
Tested these changes in the implementation of waiters for the AWS Rust SDK.
Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.