Add a name property to error structures #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Jan 13, 2020
mtdowling
reviewed
Jan 13, 2020
| @@ -158,6 +158,7 @@ private void renderErrorStructure() { | |||
|
|
|||
| writer.openBlock("export interface $L extends $L {", symbol.getName(), extendsFrom); | |||
| writer.write("__type: $S;", shape.getId().getName()); | |||
| writer.write("name: $S;", shape.getId().getName()); | |||
There was a problem hiding this comment.
I thought we were just special casing exceptions. Why is this needed on all structures? Why would we need this and __type?
There was a problem hiding this comment.
This is in the code for exception structures renderErrorStructure, as to the why we have both I think that's #92.
There was a problem hiding this comment.
Ok. This needs to be addressed in a followup PR.
There was a problem hiding this comment.
Issue created for removing __type #96
mtdowling
approved these changes
Jan 13, 2020
trivikr
added a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Jan 13, 2020
trivikr
added a commit
to aws/aws-sdk-js-v3
that referenced
this pull request
Jan 13, 2020
AllanZhengYP
pushed a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
trivikr
added a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
trivikr
added a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
trivikr
added a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Adds API Gateway Middleware. Adds method to define custom middleware. Adds support for MiddlewareDefinitions
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
* Adds API Gateway Middleware. Adds method to define custom middleware. Adds support for MiddlewareDefinitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.