New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name to exceptions in models/index.ts #94

Closed

trivikr opened this issue Jan 13, 2020 · 1 comment · Fixed by #95

Contributor

trivikr commented Jan 13, 2020

Describe the bug
Add name to exceptions in models/index.ts
Refs:

PR which added name to error add error name to error deser #92
CodeGen CI failure chore: add name to client Errors aws/aws-sdk-js-v3#724 (comment)

To Reproduce
Run CodeGen with latest smithy-typescript having fix in #92

Expected behavior
CodeGen CI succeeds

Contributor Author

trivikr commented Jan 13, 2020

Code which adds __type to Exception in models/index.ts https://github.com/awslabs/smithy-typescript/blob/afd715a3eb49cc4565cf2e19452d09462051507f/smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructureGenerator.java#L160

kstich mentioned this issue

Add a name property to error structures #95

Merged

kstich closed this as completed in #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment