chore: switch to platform AbortController & Signal implementations after dropping Node.js 14 #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter dropping Node.js 14
trivikr
approved these changes
Jun 14, 2024
|
Verified that |
Co-authored-by: Trivikram Kamat <[email protected]>
Co-authored-by: Trivikram Kamat <[email protected]>
haydenbaker
approved these changes
Jun 17, 2024
syall
suggested changes
Jun 18, 2024
There was a problem hiding this comment.
The jest fit needs to be reverted.
Is there a reason for the addEventListener() and .onabort branching? Is it to differentiate the platform` and custom controller implementation we had?
It'd also be nice to import every reference of the deprecated AbortController as `DeprecatedAbortController as you did in some files already.
Comment on lines
+6
to
+8
| export interface AbortHandler { | ||
| (this: AbortSignal | DeprecatedAbortSignal, ev: any): any; | ||
| } |
There was a problem hiding this comment.
nit question: will this ever need to be scoped down or have extra arguments?
There was a problem hiding this comment.
this should be ev: Event -> void, but I wouldn't change it at this point for compatibility
kuhe
commented
Jun 18, 2024
syall
approved these changes
Jun 18, 2024
|
confirmed TS22 is action runner memory issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes aws/aws-sdk-js-v3#4872
fixes #974
this deprecates our own Abort types and implementation and switches to the platform types where available.
AbortController / AbortSignal are available in Node.js 16+.